On 05/18/2018 12:28 AM, Jiri Pirko wrote: > From: Jiri Pirko <j...@mellanox.com> > > This patchset resolves 2 issues we have right now: > 1) There are many netdevices / ports in the system, for port, pf, vf > represenatation but the user has no way to see which is which > 2) The ndo_get_phys_port_name is implemented in each driver separatelly, > which may lead to inconsistent names between drivers. > > This patchset introduces port flavours which should address the first > problem. In this initial patchset, I focus on DSA and their port > flavours. As a follow-up, I plan to add PF and VF representor flavours. > However, that needs additional dependencies in drivers (nfp, mlx5). > > The common phys_port_name generation is used by mlxsw. An example output > for mlxsw looks like this: > > # devlink port > ... > pci/0000:03:00.0/59: type eth netdev enp3s0np4 flavour physical number 4 > pci/0000:03:00.0/61: type eth netdev enp3s0np1 flavour physical number 1 > pci/0000:03:00.0/63: type eth netdev enp3s0np2 flavour physical number 2 > pci/0000:03:00.0/49: type eth netdev enp3s0np8s0 flavour physical number 8 > split_group 8 subport 0 > pci/0000:03:00.0/50: type eth netdev enp3s0np8s1 flavour physical number 8 > split_group 8 subport 1 > pci/0000:03:00.0/51: type eth netdev enp3s0np8s2 flavour physical number 8 > split_group 8 subport 2 > pci/0000:03:00.0/52: type eth netdev enp3s0np8s3 flavour physical number 8 > split_group 8 subport 3 > > As you can see, the netdev names are generated according to the flavour > and port number. In case the port is split, the split subnumber is also > included. > > An example output for dsa_loop testing module looks like this: > # devlink port > mdio_bus/fixed-0:1f/0: type eth netdev lan1 flavour physical number 0 > mdio_bus/fixed-0:1f/1: type eth netdev lan2 flavour physical number 1 > mdio_bus/fixed-0:1f/2: type eth netdev lan3 flavour physical number 2 > mdio_bus/fixed-0:1f/3: type eth netdev lan4 flavour physical number 3 > mdio_bus/fixed-0:1f/4: type notset > mdio_bus/fixed-0:1f/5: type notset flavour cpu number 5 > mdio_bus/fixed-0:1f/6: type notset > mdio_bus/fixed-0:1f/7: type notset > mdio_bus/fixed-0:1f/8: type notset > mdio_bus/fixed-0:1f/9: type notset > mdio_bus/fixed-0:1f/10: type notset > mdio_bus/fixed-0:1f/11: type notset
Reviewed-by: Florian Fainelli <f.faine...@gmail.com> Tested-by: Florian Fainelli <f.faine...@gmail.com> Thanks! -- Florian
