>> + >> + spin_lock(&aq_nic->aq_spinlock); >> + >> + if (netif_running(ndev)) >> + dev_close(ndev); > > I don't think you can hold a spinlock around dev_close()/dev_open() > calls.
Thanks Jakub, think you are right, will consider changing this lock to mutex. >> + if (!netif_running(ndev)) >> + err = dev_open(ndev); > > Will this not open the device regardless if it was open before or not? Correct, thanks! BR, Igor