Hi Tejaswi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net/master]

url:    
https://github.com/0day-ci/linux/commits/Tejaswi-Tanikella/ipv4-igmp-use-alarmtimer-to-prevent-delayed-reports/20180611-195615
config: x86_64-randconfig-x003-201823 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   net/ipv4/igmp.c: In function 'igmp_mc_seq_show':
>> net/ipv4/igmp.c:2819:11: error: implicit declaration of function 
>> 'ktime_to_jiffies'; did you mean 'timeval_to_jiffies'? 
>> [-Werror=implicit-function-declaration]
      delta = ktime_to_jiffies(alarm_expires_remaining(&im->alarm));
              ^~~~~~~~~~~~~~~~
              timeval_to_jiffies
>> net/ipv4/igmp.c:2819:28: error: implicit declaration of function 
>> 'alarm_expires_remaining'; did you mean 'hrtimer_expires_remaining'? 
>> [-Werror=implicit-function-declaration]
      delta = ktime_to_jiffies(alarm_expires_remaining(&im->alarm));
                               ^~~~~~~~~~~~~~~~~~~~~~~
                               hrtimer_expires_remaining
>> net/ipv4/igmp.c:2819:55: error: 'struct ip_mc_list' has no member named 
>> 'alarm'
      delta = ktime_to_jiffies(alarm_expires_remaining(&im->alarm));
                                                          ^~
   cc1: some warnings being treated as errors

vim +2819 net/ipv4/igmp.c

  2813  
  2814                  if (rcu_access_pointer(state->in_dev->mc_list) == im) {
  2815                          seq_printf(seq, "%d\t%-10s: %5d %7s\n",
  2816                                     state->dev->ifindex, 
state->dev->name, state->in_dev->mc_count, querier);
  2817                  }
  2818  
> 2819                  delta = 
> ktime_to_jiffies(alarm_expires_remaining(&im->alarm));
  2820                  seq_printf(seq,
  2821                             "\t\t\t\t%08X %5d %d:%08lX\t\t%d\n",
  2822                             im->multiaddr, im->users,
  2823                             im->tm_running,
  2824                             im->tm_running ? 
jiffies_delta_to_clock_t(delta) : 0,
  2825                             im->reporter);
  2826          }
  2827          return 0;
  2828  }
  2829  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to