Hi Toshiaki,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on bpf/master]

url:    
https://github.com/0day-ci/linux/commits/Toshiaki-Makita/xdp-Fix-handling-of-devmap-in-generic-XDP/20180613-161204
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git master
config: i386-randconfig-a1-201823 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   In file included from net//bpf/test_run.c:7:0:
>> include/linux/bpf.h:594:16: warning: 'struct sk_buff' declared inside 
>> parameter list
            struct bpf_prog *xdp_prog)
                   ^
>> include/linux/bpf.h:594:16: warning: its scope is only this definition or 
>> declaration, which is probably not what you want

vim +594 include/linux/bpf.h

   591  
   592  static inline int dev_map_generic_redirect(struct bpf_dtab_netdev *dst,
   593                                             struct sk_buff *skb,
 > 594                                             struct bpf_prog *xdp_prog)
   595  {
   596          return 0;
   597  }
   598  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to