Thu, Jun 14, 2018 at 01:11:30PM CEST, ilias.apalodi...@linaro.org wrote: [...]
>@@ -2711,6 +2789,10 @@ static int cpsw_probe_dt(struct cpsw_platform_data >*data, > if (of_property_read_bool(node, "dual_emac")) > data->switch_mode = CPSW_DUAL_EMAC; > >+ /* switchdev overrides DTS */ >+ if (IS_ENABLED(CONFIG_TI_CPSW_SWITCHDEV)) >+ data->switch_mode = CPSW_SWITCHDEV; So you force CPSW_SWITCHDEV mode if the CONFIG_TI_CPSW_SWITCHDEV is enabled. That does not sound right. I think that user should tell what mode does he want regardless what the kernel config is.
