[patch net-next 3/9] net: sched: cls_flower: move key/mask dumping into a separate function

[Jiri Pirko]

From: Jiri Pirko <j...@mellanox.com>

Push key/mask dumping from fl_dump() into a separate function
fl_dump_key(), that will be reused for template dumping.

Signed-off-by: Jiri Pirko <j...@mellanox.com>
---
 net/sched/cls_flower.c | 62 ++++++++++++++++++++++++++++++--------------------
 1 file changed, 37 insertions(+), 25 deletions(-)

diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c
index 09d6c6e67f9d..76c5516357d5 100644
--- a/net/sched/cls_flower.c
+++ b/net/sched/cls_flower.c
@@ -1217,29 +1217,9 @@ static int fl_dump_key_flags(struct sk_buff *skb, u32 
flags_key, u32 flags_mask)
        return nla_put(skb, TCA_FLOWER_KEY_FLAGS_MASK, 4, &_mask);
 }
 
-static int fl_dump(struct net *net, struct tcf_proto *tp, void *fh,
-                  struct sk_buff *skb, struct tcmsg *t)
+static int fl_dump_key(struct sk_buff *skb, struct net *net,
+                      struct fl_flow_key *key, struct fl_flow_key *mask)
 {
-       struct cls_fl_filter *f = fh;
-       struct nlattr *nest;
-       struct fl_flow_key *key, *mask;
-
-       if (!f)
-               return skb->len;
-
-       t->tcm_handle = f->handle;
-
-       nest = nla_nest_start(skb, TCA_OPTIONS);
-       if (!nest)
-               goto nla_put_failure;
-
-       if (f->res.classid &&
-           nla_put_u32(skb, TCA_FLOWER_CLASSID, f->res.classid))
-               goto nla_put_failure;
-
-       key = &f->key;
-       mask = &f->mask->key;
-
        if (mask->indev_ifindex) {
                struct net_device *dev;
 
@@ -1248,9 +1228,6 @@ static int fl_dump(struct net *net, struct tcf_proto *tp, 
void *fh,
                        goto nla_put_failure;
        }
 
-       if (!tc_skip_hw(f->flags))
-               fl_hw_update_stats(tp, f);
-
        if (fl_dump_key_val(skb, key->eth.dst, TCA_FLOWER_KEY_ETH_DST,
                            mask->eth.dst, TCA_FLOWER_KEY_ETH_DST_MASK,
                            sizeof(key->eth.dst)) ||
@@ -1404,6 +1381,41 @@ static int fl_dump(struct net *net, struct tcf_proto 
*tp, void *fh,
        if (fl_dump_key_flags(skb, key->control.flags, mask->control.flags))
                goto nla_put_failure;
 
+       return 0;
+
+nla_put_failure:
+       return -EMSGSIZE;
+}
+
+static int fl_dump(struct net *net, struct tcf_proto *tp, void *fh,
+                  struct sk_buff *skb, struct tcmsg *t)
+{
+       struct cls_fl_filter *f = fh;
+       struct nlattr *nest;
+       struct fl_flow_key *key, *mask;
+
+       if (!f)
+               return skb->len;
+
+       t->tcm_handle = f->handle;
+
+       nest = nla_nest_start(skb, TCA_OPTIONS);
+       if (!nest)
+               goto nla_put_failure;
+
+       if (f->res.classid &&
+           nla_put_u32(skb, TCA_FLOWER_CLASSID, f->res.classid))
+               goto nla_put_failure;
+
+       key = &f->key;
+       mask = &f->mask->key;
+
+       if (fl_dump_key(skb, net, key, mask))
+               goto nla_put_failure;
+
+       if (!tc_skip_hw(f->flags))
+               fl_hw_update_stats(tp, f);
+
        if (f->flags && nla_put_u32(skb, TCA_FLOWER_FLAGS, f->flags))
                goto nla_put_failure;
 
-- 
2.14.4