Hi John, Thank you for the patch! Yet something to improve:
[auto build test ERROR on net/master] url: https://github.com/0day-ci/linux/commits/Jakub-Kicinski/nfp-MPLS-and-shared-blocks-TC-offload-fixes/20180626-042358 config: i386-randconfig-x001-201825 (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers/net/ethernet/netronome/nfp/flower/offload.c: In function 'nfp_flower_setup_tc_block': >> drivers/net/ethernet/netronome/nfp/flower/offload.c:634:6: error: implicit >> declaration of function 'tcf_block_shared'; did you mean 'tcf_block_dev'? >> [-Werror=implicit-function-declaration] if (tcf_block_shared(f->block)) ^~~~~~~~~~~~~~~~ tcf_block_dev cc1: some warnings being treated as errors vim +634 drivers/net/ethernet/netronome/nfp/flower/offload.c 625 626 static int nfp_flower_setup_tc_block(struct net_device *netdev, 627 struct tc_block_offload *f) 628 { 629 struct nfp_repr *repr = netdev_priv(netdev); 630 631 if (f->binder_type != TCF_BLOCK_BINDER_TYPE_CLSACT_INGRESS) 632 return -EOPNOTSUPP; 633 > 634 if (tcf_block_shared(f->block)) 635 return -EOPNOTSUPP; 636 637 switch (f->command) { 638 case TC_BLOCK_BIND: 639 return tcf_block_cb_register(f->block, 640 nfp_flower_setup_tc_block_cb, 641 repr, repr); 642 case TC_BLOCK_UNBIND: 643 tcf_block_cb_unregister(f->block, 644 nfp_flower_setup_tc_block_cb, 645 repr); 646 return 0; 647 default: 648 return -EOPNOTSUPP; 649 } 650 } 651 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
