On 6/26/2018 3:58 AM, Willem de Bruijn wrote: > On Mon, Jun 25, 2018 at 7:06 PM Amritha Nambiar > <amritha.namb...@intel.com> wrote: >> >> Change 'skc_tx_queue_mapping' field in sock_common structure from >> 'int' to 'unsigned short' type with 0 indicating unset and >> a positive queue value being set. This way it is consistent with >> the queue_mapping field in the sk_buff. This will also accommodate >> adding a new 'unsigned short' field in sock_common in the next >> patch for rx_queue_mapping. >> >> Signed-off-by: Amritha Nambiar <amritha.namb...@intel.com> >> --- > >> static inline void sk_tx_queue_set(struct sock *sk, int tx_queue) >> { >> - sk->sk_tx_queue_mapping = tx_queue; >> + /* sk_tx_queue_mapping accept only upto a 16-bit value */ >> + WARN_ON((unsigned short)tx_queue > USHRT_MAX); >> + sk->sk_tx_queue_mapping = tx_queue + 1; >> } > > WARN_ON_ONCE to avoid flooding the kernel buffer. > Will fix.
- [net-next PATCH v4 0/7] Symmetric queue selection using ... Amritha Nambiar
- [net-next PATCH v4 1/7] net: Refactor XPS for CPUs ... Amritha Nambiar
- Re: [net-next PATCH v4 1/7] net: Refactor XPS f... Tom Herbert
- Re: [net-next PATCH v4 1/7] net: Refactor X... Nambiar, Amritha
- [net-next PATCH v4 2/7] net: Use static_key for XPS... Amritha Nambiar
- [net-next PATCH v4 3/7] net: sock: Change tx_queue_... Amritha Nambiar
- Re: [net-next PATCH v4 3/7] net: sock: Change t... Alexander Duyck
- Re: [net-next PATCH v4 3/7] net: sock: Chan... Nambiar, Amritha
- Re: [net-next PATCH v4 3/7] net: sock: Change t... Willem de Bruijn
- Re: [net-next PATCH v4 3/7] net: sock: Chan... Nambiar, Amritha
- [net-next PATCH v4 4/7] net: Record receive queue n... Amritha Nambiar
- [net-next PATCH v4 5/7] net: Enable Tx queue select... Amritha Nambiar
- Re: [net-next PATCH v4 5/7] net: Enable Tx queu... kbuild test robot
- Re: [net-next PATCH v4 5/7] net: Enable Tx queu... Willem de Bruijn
- Re: [net-next PATCH v4 5/7] net: Enable Tx ... Nambiar, Amritha
- Re: [net-next PATCH v4 5/7] net: Enable... Willem de Bruijn
- Re: [net-next PATCH v4 5/7] net: E... Nambiar, Amritha
- [net-next PATCH v4 7/7] Documentation: Add explanat... Amritha Nambiar
- [net-next PATCH v4 6/7] net-sysfs: Add interface fo... Amritha Nambiar