On Tue, Jun 26, 2018 at 1:01 AM Jiri Pirko <j...@resnulli.us> wrote: > Create dummy device with clsact first: > # ip link add type dummy > # tc qdisc add dev dummy0 clsact > > There is no template assigned by default: > # tc filter template show dev dummy0 ingress > > Add a template of type flower allowing to insert rules matching on last > 2 bytes of destination mac address: > # tc filter template add dev dummy0 ingress proto ip flower dst_mac > 00:00:00:00:00:00/00:00:00:00:FF:FF
Now you are extending 'tc filter' command with a new subcommand 'template', which looks weird. Why not make it a new property of filter like you did for chain? Like: tc filter add dev dummy0 ingress proto ip template flower which is much better IMHO.
