On 27/06/18 01:06, Eric Dumazet wrote: > On 06/26/2018 11:17 AM, Edward Cree wrote: >> Just calls netif_receive_skb() in a loop. > ... > >> +void netif_receive_skb_list(struct sk_buff_head *list) > > Please use a standard list_head and standard list operators. > > (In all your patches) > > 1) We do not want to carry a spinlock_t + count per list... > > 2) We get nice debugging features with CONFIG_DEBUG_LIST=y > > Note that we now have skb->list after > commit d4546c2509b1e9cd082e3682dcec98472e37ee5a ("net: Convert GRO SKB > handling to list_head.") So we do. That hadn't gone in yet on Monday when I last pulled net-next; I'll make sure to use it in the next spin. Thanks.
- [RFC PATCH v2 net-next 00/12] Handle multiple received pa... Edward Cree
- [RFC PATCH v2 net-next 01/12] net: core: trivial net... Edward Cree
- Re: [RFC PATCH v2 net-next 01/12] net: core: tri... Eric Dumazet
- Re: [RFC PATCH v2 net-next 01/12] net: core:... Edward Cree
- [RFC PATCH v2 net-next 02/12] sfc: batch up RX deliv... Edward Cree
- [RFC PATCH v2 net-next 03/12] net: core: unwrap skb ... Edward Cree
- [RFC PATCH v2 net-next 04/12] net: core: Another ste... Edward Cree
- [RFC PATCH v2 net-next 05/12] net: core: another lay... Edward Cree
- [RFC PATCH v2 net-next 06/12] net: core: propagate S... Edward Cree
- Re: [RFC PATCH v2 net-next 06/12] net: core: pro... Willem de Bruijn
- Re: [RFC PATCH v2 net-next 06/12] net: core:... Edward Cree
- Re: [RFC PATCH v2 net-next 06/12] net: c... Willem de Bruijn
- Re: [RFC PATCH v2 net-next 06/12] n... Edward Cree
- [RFC PATCH v2 net-next 07/12] net: ipv4: listified v... Edward Cree