> -----Original Message----- > From: Cong Wang [mailto:xiyou.wangc...@gmail.com] > Sent: Monday, June 11, 2018 1:23 PM > To: Keller, Jacob E <jacob.e.kel...@intel.com> > Cc: Kirsher, Jeffrey T <jeffrey.t.kirs...@intel.com>; da...@davemloft.net; > netdev@vger.kernel.org; nhor...@redhat.com; sassm...@redhat.com; > jogre...@redhat.com; Eric Dumazet <eduma...@google.com> > Subject: Re: [net] fq_codel: fix NULL pointer deref in fq_codel_reset > > On Mon, Jun 11, 2018 at 12:57 PM, Keller, Jacob E > <jacob.e.kel...@intel.com> wrote: > > > > I'm open to alternative suggestinos for fixing this, I think Eric suggested > > that > maybe we should just remove the ->reset() call from qdisc_destroy..? > > You can't remove ->reset() for non-failure call path. > > For failure path, yeah, but it is much simpler to just make > q->flows_cnt be 0 for this specific case.
Alright. I'll rework the patch to set flows_cnt to 0 when init fails. Thanks, Jake
