On Fri, Jul 6, 2018 at 1:24 PM Jesus Sanchez-Palencia <jesus.sanchez-palen...@intel.com> wrote: > > > > On 07/06/2018 07:12 AM, Willem de Bruijn wrote: > > From: Willem de Bruijn <will...@google.com> > > > > Recent UDP GSO and SO_TXTIME features added new fields to cookie > > structs. > > > > When adding a field, all sites where a struct is initialized have to > > be updated, which is a lot of boilerplate. Alternatively, a field can > > be initialized selectively, but this is fragile. I introduced a bug > > in udp gso where an uninitialized field was read. See also fix commit > > ("9887cba19978 ip: limit use of gso_size to udp"). > > > > Introduce initializers for structs ipcm(6)_cookie and sockc_cookie. > > > > patch 1..3 do exactly this. > > patch 4..5 make ipv4 and ipv6 handle cookies the same way and > > remove some boilerplate in doing so. > > patch 6 removes the udp gso branch that needed the above fix > > > Acked-by: Jesus Sanchez-Palencia <jesus.sanchez-palen...@intel.com> > > I've applied this series and tested SO_TXTIME + the etf qdisc and everything > is > working just fine.
Thanks for testing, Jesus! I also ran the udpgso and txtimestamp tests (and am expanding the second to run as part of kselftest, and have ipv6 and cmsg support).