From: Andrew Lunn <and...@lunn.ch> Date: Tue, 17 Jul 2018 23:48:53 +0200
> @@ -319,6 +337,8 @@ int mv88e6xxx_ptp_setup(struct mv88e6xxx_chip *chip) > { > int i; > > + const struct mv88e6xxx_ptp_ops *ptp_ops = chip->info->ops->ptp_ops; > + Please keep the local variables together here. Otherwise, this series looks good to me.