Hi Dave Can you still apply the rest of two patches in the series or do I need to send them again separately?
Regards Vakul ________________________________ From: [email protected] <[email protected]> on behalf of David Miller <[email protected]> Sent: Tuesday, July 24, 2018 10:11:09 AM To: [email protected] Cc: Vakul Garg; [email protected]; [email protected]; [email protected]; [email protected] Subject: Re: [net-next v5 3/3] net/tls: Remove redundant array allocation. From: Dave Watson <[email protected]> Date: Mon, 23 Jul 2018 09:35:09 -0700 > I don't think this patch is safe as-is. sgin_arr is a stack array of > size MAX_SKB_FRAGS (+ overhead), while my read of skb_cow_data is that > it walks the whole chain of skbs from skb->next, and can return any > number of segments. Therefore we need to heap allocate. I think I > copied the IPSEC code here. Ok I see what you are saying. So it means that, when a non-NULL sgout is passed into decrypt_skb(), via decrypt_skb_update(), via tls_sw_recvmsg() it means that it is the zerocopy case and you know that you only have page frags and no SKB frag list, right? I agree with you that this change is therefore incorrect.
