On Tue, 24 Jul 2018 19:26:38 +0200 Lubomir Rintel <lkund...@v3.sk> wrote:
> This partly reverts 8f0807023d067e2bb585a2ae8da93e59689d10f1, bringing > back the umount(/sys) attempt. > > In a LXC container we're unable to umount the sysfs instance, nor mount > a read-write one. We still are able to create a new read-only instance. > > Nevertheless, it still makes sense to attempt the umount() even though > the sysfs is mounted read-only. Otherwise we may end up attempting to > mount a sysfs with the same flags as is already mounted, resulting in > an EBUSY error (meaning "Already mounted"). > > Perhaps this is not a very likely scenario in real world, but we hit > it in NetworkManager test suite and makes netns_switch() somewhat more > robust. It also fixes the case, when /sys wasn't mounted at all. > > Signed-off-by: Lubomir Rintel <lkund...@v3.sk> Makes sens applied.
