On Tue, Aug 28, 2018 at 02:44:32PM +0200, Björn Töpel wrote: > From: Björn Töpel <bjorn.to...@intel.com> > > This patch adds zero-copy Rx support for AF_XDP sockets. Instead of > allocating buffers of type MEM_TYPE_PAGE_SHARED, the Rx frames are > allocated as MEM_TYPE_ZERO_COPY when AF_XDP is enabled for a certain > queue. > > All AF_XDP specific functions are added to a new file, i40e_xsk.c. > > Note that when AF_XDP zero-copy is enabled, the XDP action XDP_PASS > will allocate a new buffer and copy the zero-copy frame prior passing > it to the kernel stack. > > Signed-off-by: Björn Töpel <bjorn.to...@intel.com> ... > +/** > + * i40e_construct_skb_zc - Create skbufff from zero-copy Rx buffer
typo sk_buff overall the set looks great to me. The driver side changes look particularly clean and independent from skb path of the driver. I think the issues brought up by other reviews are not blockers for the set, but certainly should be addressed in the follow up patches.
