From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 19 Oct 2006 10:15:43 -0700
> The original skb management for netpoll was a mess, it had two queue paths > and a callback. This changes it to have a per-instance transmit queue > and use a tasklet rather than a work queue for the congested case. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> I think you mis-diffed this one: - WARN_ON(skb->protocol == 0); That line doesn't exist in my copy of net/core/netpoll.c even with your first patch applied. Also, you forgot to remove the ->drop callback pointer from struct netpoll, which you should do if it really isn't used any more. I think you might run into problems there, as I believe the netdump stuff does make non-trivial use of the ->drop callback. Indeed, it uses the ->dump callback for invoking a special netpoll_start_netdump() function. I'm pretty sure ->dump was created specifically to accomodate netdump. So this is something else which will need to be worked out before we can apply this patch. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
