From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Fri, 20 Oct 2006 15:30:27 -0700

> +             spin_lock_irqsave(&netpoll_txq.lock, flags);
> +             for (skb = (struct sk_buff *)netpoll_txq.next;
> +                  skb != (struct sk_buff *)&netpoll_txq; skb = next) {
> +                     next = skb->next;
> +                     if (skb->dev == dev)
> +                             skb_unlink(skb, &netpoll_txq);
> +             }
> +             spin_unlock_irqrestore(&netpoll_txq.lock, flags);
>       }

All SKBs removed here will be leaked, nothing frees them up.

Since #2 and #3 depend upon this patch, I'll hold off on those
until you fix this bug.

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to