> On Sep 24, 2018, at 2:05 PM, Eric Dumazet <eduma...@google.com> wrote: > >> >> Interesting, maybe a bnxt specific issue. >> >> It seems their model is to process TX/RX notification in the same queue, >> they throw away RX events if budget == 0 >> >> It means commit e7b9569102995ebc26821789628eef45bd9840d8 is wrong and >> must be reverted. >> >> Otherwise, we have a possibility of blocking a queue under netpoll pressure. > > Hmm, actually a revert might not be enough, since code at lines 2030-2031 > would fire and we might not call napi_complete_done() anyway. > > Unfortunately this driver logic is quite complex. > > Could you test on other NIC eventually ? > It actually runs OK on ixgbe. @Michael, could you please help us with this? Thanks, Song
- [PATCH net 13/15] bnxt: remove ndo_poll_controller Eric Dumazet
- Re: [PATCH net 00/15] netpoll: avoid capture effects for NAPI... David Miller
- Re: [PATCH net 00/15] netpoll: avoid capture effects for NAPI... David Miller
- Re: [PATCH net 00/15] netpoll: avoid capture effects for... Eric Dumazet
- Re: [PATCH net 00/15] netpoll: avoid capture effects... Song Liu
- Re: [PATCH net 00/15] netpoll: avoid capture eff... Eric Dumazet
- Re: [PATCH net 00/15] netpoll: avoid capture... Song Liu
- Re: [PATCH net 00/15] netpoll: avoid ca... Eric Dumazet
- Re: [PATCH net 00/15] netpoll: avoi... Eric Dumazet
- Re: [PATCH net 00/15] netpoll: avoi... Song Liu
- Re: [PATCH net 00/15] netpoll: avoi... Michael Chan
- Re: [PATCH net 00/15] netpoll: avoi... Eric Dumazet
- Re: [PATCH net 00/15] netpoll: avoi... Michael Chan
- Re: [PATCH net 00/15] netpoll: avoi... Song Liu
- Re: [PATCH net 00/15] netpoll: avoi... Michael Chan
- Re: [PATCH net 00/15] netpoll: avoid capture effects... Song Liu