On Mon, 2006-10-23 at 20:56, Jiri Benc wrote: > On Mon, 23 Oct 2006 14:48:00 +0200, Johannes Berg wrote: > > On Mon, 2006-10-23 at 14:40 +0200, Jiri Benc wrote: > > > I don't like extending ieee80211_tx_control by 16 more bytes. The > > > driver is required to store a copy of each ieee80211_tx_control > > > (because it's copied to ieee80211_tx_status). I don't have a better > > > idea, though. Anybody? > > > > A pointer that goes somewhere else? I suppose it could even be in the > > skb's cb field. > > Yes, that could work. Thanks! > > > Also, something I just came to think of, bcm43xx does phase2 mixing in > > hw and requires phase1 in software. Do we handle that with or without > > this patch? If not, it'd be nice to fix it up together. > > It's not supported now. And it's really a good idea to extend the patch > to support the bcm43xx case as well. > > Jiri
It's really strange bcm43xx only does phase2 mixing in hw. With all the code that does phase2 mixing, doing phase1 mixing is very cheap. With Jiri's ieee80211_tx_ctrl_common patch, I think we can put the rc4key or phase1 key in ieee80211_tx_control with each TX packet. Thanks, Hong - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
