On Wed 03 Oct 2018 at 16:08, Davide Caratti <dcara...@redhat.com> wrote: > On Wed, 2018-10-03 at 18:29 +0300, Vlad Buslov wrote: >> Recently flower classifier was updated to expose count of devices that >> filter is offloaded to. Add support to print this counter as 'in_hw_count'. >> >> Signed-off-by: Vlad Buslov <vla...@mellanox.com> >> Acked-by: Jiri Pirko <j...@mellanox.com> >> --- >> tc/f_flower.c | 10 +++++++++- >> 1 file changed, 9 insertions(+), 1 deletion(-) >> >> diff --git a/tc/f_flower.c b/tc/f_flower.c >> index 59e5f572c542..cbacc664d397 100644 > > hello Vlad! > >> --- a/tc/f_flower.c >> +++ b/tc/f_flower.c >> @@ -1585,8 +1585,16 @@ static int flower_print_opt(struct filter_util *qu, >> FILE *f, >> if (flags & TCA_CLS_FLAGS_SKIP_SW) >> print_bool(PRINT_ANY, "skip_sw", "\n skip_sw", true); >> >> - if (flags & TCA_CLS_FLAGS_IN_HW) >> + if (flags & TCA_CLS_FLAGS_IN_HW) { >> print_bool(PRINT_ANY, "in_hw", "\n in_hw", true); >> + >> + if (tb[TCA_FLOWER_IN_HW_COUNT]) { >> + __u32 count = >> rta_getattr_u32(tb[TCA_FLOWER_IN_HW_COUNT]); >> + >> + print_uint(PRINT_ANY, "in_hw_count", >> + " in_hw_count %d", count); > ^^ maybe using %u in the format is better? > > thanks!
Hello Davide! Sure. I'll send V2 with "%u". Thanks, Vlad