From: Davide Caratti <dcara...@redhat.com> Date: Wed, 3 Oct 2018 15:20:58 +0200
> the be2net implementation of .ndo_tunnel_{add,del}() changes the value of > NETIF_F_GSO_UDP_TUNNEL bit in 'features' and 'hw_features', but it forgets > to call netdev_features_change(). Moreover, ethtool setting for that bit > can potentially be reverted after a tunnel is added or removed. > > GSO already does software segmentation when 'hw_enc_features' is 0, even > if VXLAN offload is turned on. In addition, commit 096de2f83ebc ("benet: > stricter vxlan offloading check in be_features_check") avoids hardware > segmentation of non-VXLAN tunneled packets, or VXLAN packets having wrong > destination port. So, it's safe to avoid flipping the above feature on > addition/deletion of VXLAN tunnels. > > Fixes: 630f4b70567f ("be2net: Export tunnel offloads only when a VxLAN tunnel > is created") > Signed-off-by: Davide Caratti <dcara...@redhat.com> Applied, thank you.