From: <akiy...@amazon.com>
Date: Mon, 8 Oct 2018 15:28:41 +0300
> From: Arthur Kiyanovski <akiy...@amazon.com>
>
> Memory mapped with devm_ioremap is automatically freed when the driver
> is disconnected from the device. Therefore there is no need to
> explicitly call devm_iounmap.
>
> Signed-off-by: Arthur Kiyanovski <akiy...@amazon.com>
> ---
> drivers/net/ethernet/amazon/ena/ena_netdev.c | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c
> b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> index 25621a2..23f2dda 100644
> --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
> +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> @@ -3099,15 +3099,7 @@ static int ena_rss_init_default(struct ena_adapter
> *adapter)
>
> static void ena_release_bars(struct ena_com_dev *ena_dev, struct pci_dev
> *pdev)
> {
> - int release_bars;
> -
> - if (ena_dev->mem_bar)
> - devm_iounmap(&pdev->dev, ena_dev->mem_bar);
> -
> - if (ena_dev->reg_bar)
> - devm_iounmap(&pdev->dev, ena_dev->reg_bar);
> -
> - release_bars = pci_select_bars(pdev, IORESOURCE_MEM) & ENA_BAR_MASK;
> + int release_bars = pci_select_bars(pdev, IORESOURCE_MEM) & ENA_BAR_MASK;
> pci_release_selected_regions(pdev, release_bars);
Always have an empty line between local variable declarations and actual
function code.
