On Wed, Oct 25, 2006 at 03:41:50PM -0700, David Kimdon wrote: > > I don't actually know the implications of that first hunk where we do > "arc4" -> "ecb(arc4)". I look though the various commits by Herbert > Xu and that appeared to be the right thing.
Basically if you encrypt/decrypt more than a block at a time and you're using ECB then ecb(arc4) is right. So the changes to net/d80211/wep.c are good. If you're only encrypting/decrypting a single block then you should use the cipher interface. So net/d80211/aes_ccm.c should do that instead. See drivers/net/wirless/airo.c for an example of that. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
