On Fri, 12 Oct 2018 17:34:32 +0200 Sabrina Dubroca <s...@queasysnail.net> wrote:
> Stephen converted macsec's sci to use 0xhex, but 0xhex handles > unsigned int's, not 64 bits ints. Thus, the output of the "ip macsec > show" command is mangled, with half of the SCI replaced with 0s: > > # ip macsec show > 11: macsec0: [...] > cipher suite: GCM-AES-128, using ICV length 16 > TXSC: 0000000001560001 on SA 0 > > # ip -d link show macsec0 > 11: macsec0@ens3: [...] > link/ether 52:54:00:12:01:56 brd ff:ff:ff:ff:ff:ff promiscuity 0 > macsec sci 5254001201560001 [...] > > where TXSC and sci should match. > > Fixes: c0b904de6211 ("macsec: support JSON") > Signed-off-by: Sabrina Dubroca <s...@queasysnail.net> Thanks for finding this. We should add JSON (and macsec) to tests.