Eric Dumazet <eric.duma...@gmail.com> : > On 10/18/2018 03:59 PM, Francois Romieu wrote: > > Eric Dumazet <eric.duma...@gmail.com> : > > [...] > >> One has to wonder why rtl8169_poll(), which might be called in a loop > >> under DOS, > >> has to call rtl_ack_events() ? > > > > So as to cover a wider temporal range before any event can trigger an > > extra irq. I was more worried about irq cost than about IO cost (and > > I still am). > > > Normally the IRQ would not be enabled under DOS.
Yes. My concern was not the DOS situation when NAPI runs at full speed. As far as I was able to experiment with it, the driver did not seem too bad here. The location of the ack targets the interim situation where the IRQ rate can increase before NAPI kicks in. By increasing the time range whose events can be acked, the maximum irq rate should be lowered. -- Ueimor
