Re: [PATCH net-next 02/17] net: sched: protect block state with spinlock

[Vlad Buslov]

On Tue 13 Nov 2018 at 10:07, Stefano Brivio <sbri...@redhat.com> wrote:
> Vlad,
>
> On Mon, 12 Nov 2018 09:28:59 -0800 (PST)
> David Miller <da...@davemloft.net> wrote:
>
>> From: Vlad Buslov <vla...@mellanox.com>
>> Date: Mon, 12 Nov 2018 09:55:31 +0200
>> 
>> > +#define ASSERT_BLOCK_LOCKED(block)                                        
>> > \
>> > +  WARN_ONCE(!spin_is_locked(&(block)->lock),              \
>> > +            "BLOCK: assertion failed at %s (%d)\n", __FILE__,  __LINE__)  
>> 
>> spin_is_locked() is not usable for assertions.
>
> See also b86077207d0c ("igbvf: Replace spin_is_locked() with
> lockdep").

Stefano,

Thanks for the tip. I will check it out.

Vlad.