On 11/21/18 4:01 AM, Nicolas Dichtel wrote: > diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c > index 92730905886c..fc568cd0b560 100644 > --- a/net/core/net_namespace.c > +++ b/net/core/net_namespace.c > @@ -740,7 +740,7 @@ static int rtnl_net_get_size(void) > } > > static int rtnl_net_fill(struct sk_buff *skb, u32 portid, u32 seq, int flags, > - int cmd, int nsid) > + int cmd, int nsid, bool add_ref, int ref_nsid) > { > struct nlmsghdr *nlh; > struct rtgenmsg *rth; > @@ -755,6 +755,9 @@ static int rtnl_net_fill(struct sk_buff *skb, u32 portid, > u32 seq, int flags, > if (nla_put_s32(skb, NETNSA_NSID, nsid)) > goto nla_put_failure; > > + if (add_ref && nla_put_s32(skb, NETNSA_CURRENT_NSID, ref_nsid)) > + goto nla_put_failure;
Why not use ref_nsid >= 0 and drop the add_ref argument?