Re: [PATCH net-next,v3 10/12] dsa: bcm_sf2: use flow_rule infrastructure

[Florian Fainelli]

On 11/20/2018 6:51 PM, Pablo Neira Ayuso wrote:
> Update this driver to use the flow_rule infrastructure, hence we can use
> the same code to populate hardware IR from ethtool_rx_flow and the
> cls_flower interfaces.
> 
> Signed-off-by: Pablo Neira Ayuso <pa...@netfilter.org>
> ---

[snip]

> @@ -398,9 +411,10 @@ static int bcm_sf2_cfp_ipv4_rule_set(struct bcm_sf2_priv 
> *priv, int port,
>        * Reserved             [1]
>        * UDF_Valid[8]         [0]
>        */
> -     core_writel(priv, v4_spec->tos << IPTOS_SHIFT |
> -                 ip_proto << IPPROTO_SHIFT | ip_frag << IP_FRAG_SHIFT |
> -                 udf_upper_bits(num_udf),
> +     core_writel(priv, ip.key->tos << IPTOS_SHIFT |
> +                       basic.key->n_proto << IPPROTO_SHIFT |
> +                       ip_frag << IP_FRAG_SHIFT |
> +                       udf_upper_bits(num_udf),

Can you maintain the alignment of the arguments here?

Every else looked okay, but I need to check the ipv6 structure to make
sure we can access it as 4x32 bits words like we did before.
-- 
Florian