From: Jerin Jacob <jerinjac...@gmail.com>
Date: Sat,  1 Dec 2018 14:43:51 +0530

> +#define FLOW_KEY_TYPE_PORT   BIT(0)
> +#define FLOW_KEY_TYPE_IPV4   BIT(1)
> +#define FLOW_KEY_TYPE_IPV6   BIT(2)
> +#define FLOW_KEY_TYPE_TCP    BIT(3)
> +#define FLOW_KEY_TYPE_UDP    BIT(4)
> +#define FLOW_KEY_TYPE_SCTP   BIT(5)

This is asking for serious global namespace collisions, as we have
various FLOW_* definitions coming from include/uapi/linux/pkt_cls.h
for example.

Please put some appropriate driver prefix to these macro names.

Thanks.

Reply via email to