> From: Sørensen, Stefan <stefan.soren...@spectralink.com> > Sent: Monday, December 03, 2018 5:50 AM > To: da...@davemloft.net; Tristram Ha - C24268 > <tristram...@microchip.com> > Cc: netdev@vger.kernel.org; pa...@ucw.cz; f.faine...@gmail.com; > UNGLinuxDriver <unglinuxdri...@microchip.com>; and...@lunn.ch > Subject: Re: [PATCH v4 net-next 5/6] net: dsa: microchip: break KSZ9477 DSA > driver into two files > > On Tue, 2018-11-20 at 15:55 -0800, tristram...@microchip.com wrote: > > From: Tristram Ha <tristram...@microchip.com> > > > > Break KSZ9477 DSA driver into two files in preparation to add more > > KSZ switch drivers. > > Add common functions in ksz_common.h so that other KSZ switch drivers > > can access code in ksz_common.c. > > Add ksz_spi.h for common functions used by KSZ switch SPI drivers. > > With this patch, the ethernet on my EVB-KSZ9477 is now completely non- > functional, link is detected on the LAN ports, but no packets are > forwarded to/from the CPU port. > > Looking through the patch, it does much more than splitting up the > existing code, e.g. the PORT_VLAN_MEMBERSHIP register is now written to > - I suspect that change may be responsible for the problem. >
It is more likely the RGMII interface is not set properly. There are upcoming patches that address this issue. The primary way to set RGMII delay is to set phy-mode to "rgmii-txid" inside the device tree under the ksz9477 definition. The chip can be set to MII/RMII with strap options, but there is no way to change RGMII delay settings. The patch will try to get the mode from hardware first. When it is not set in device tree this mode will be used. When it is different from the one set a warning will be displayed. The one from device tree will be the one to use. This will patch will support KSZ9893, a 3-port variant of KSZ9477. It shares most of the registers but has a different tail tag format, and uses a different RGMII setting in the evaluation board. Or do you use a different CPU port rather than the default port 6?
