On Monday 06 November 2006 16:48, Larry Finger wrote: > From: Adrian Bunk <[EMAIL PROTECTED]> > > The Coverity checker noted that these "if (err)"'s couldn't ever be > true. > > It seems the intention was to check the return values of the > bcm43xx_pci_write_config32()'s?
Whoops, I thought I had fixed this bug long time ago. The patch is correct. > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > Signed-off-by: Larry Finger <[EMAIL PROTECTED]> Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> > Index: wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c > =================================================================== > --- wireless-2.6.orig/drivers/net/wireless/bcm43xx/bcm43xx_main.c > +++ wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c > @@ -750,7 +750,7 @@ int bcm43xx_sprom_write(struct bcm43xx_p > if (err) > goto err_ctlreg; > spromctl |= 0x10; /* SPROM WRITE enable. */ > - bcm43xx_pci_write_config32(bcm, BCM43xx_PCICFG_SPROMCTL, spromctl); > + err = bcm43xx_pci_write_config32(bcm, BCM43xx_PCICFG_SPROMCTL, > spromctl); > if (err) > goto err_ctlreg; > /* We must burn lots of CPU cycles here, but that does not > @@ -772,7 +772,7 @@ int bcm43xx_sprom_write(struct bcm43xx_p > mdelay(20); > } > spromctl &= ~0x10; /* SPROM WRITE enable. */ > - bcm43xx_pci_write_config32(bcm, BCM43xx_PCICFG_SPROMCTL, spromctl); > + err = bcm43xx_pci_write_config32(bcm, BCM43xx_PCICFG_SPROMCTL, > spromctl); > if (err) > goto err_ctlreg; > mdelay(500); > -- Greetings Michael. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
