From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Thu, 26 Oct 2006 19:29:34 -0700

> It was a dark and stormy night when Steve first saw the
> netpoll beast. The beast was odd, and misshapen but not
> extremely ugly.
> 
> "Let me take off one of your warts" he said. This wart
> is where you tried to make an skb list yourself. If the
> beast had ever run out of memory, he would have stupefied
> himself unnecessarily.
> 
> The first try was painful, so he tried again till the bleeding
> stopped.

Maybe spend some time with compile tests instead of the cute
story line? :-)

> -static DEFINE_SPINLOCK(skb_list_lock);
> -static int nr_skbs;
> -static struct sk_buff *skbs;
> +static struct sk_buff_head skb_pool;

skb_pool is a scaler.

> +     spin_lock_irqsave(&skb_pool->lock, flags);

Yet is being accessed as a pointer.

net/core/netpoll.c:191: error: invalid type argument of $,1rx(B->$,1ry(B
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to