On Dec 7 2006 19:25, [EMAIL PROTECTED] wrote:
>+void t3_set_reg_field(struct adapter *adapter, unsigned int addr, u32 mask,
>+ u32 val)
>+{
>+ u32 v = t3_read_reg(adapter, addr) & ~mask;
>+
>+ t3_write_reg(adapter, addr, v | val);
>+ (void)t3_read_reg(adapter, addr); /* flush */
>+}
Drop casts to void. (Also elsewhere)
>+int t3_mc7_bd_read(struct mc7 *mc7, unsigned int start, unsigned int n,
>+ u64 * buf)
>+{
>+ static int shift[] = { 0, 0, 16, 24 };
>+ static int step[] = { 0, 32, 16, 8 };
Unless these are modified during operation of this driver, make it const.
>+/*
>+ * Partial EEPROM Vital Product Data structure. Includes only the ID and
>+ * VPD-R sections.
>+ */
>+struct t3_vpd {
>+ u8 id_tag;
>+ u8 id_len[2];
>+ u8 id_data[16];
>+ u8 vpdr_tag;
>+ u8 vpdr_len[2];
>+ VPD_ENTRY(pn, 16); /* part number */
>+ VPD_ENTRY(ec, 16); /* EC level */
>+ VPD_ENTRY(sn, 16); /* serial number */
s/^\t /\t/;
>+static int get_vpd_params(struct adapter *adapter, struct vpd_params *p)
>+{
>+ int i, addr, ret;
>+ struct t3_vpd vpd;
>+
>+ /*
>+ * Card information is normally at VPD_BASE but some early cards had
>+ * it at 0.
>+ */
>+ ret = t3_seeprom_read(adapter, VPD_BASE, (u32 *) & vpd);
>+ if (ret)
>+ return ret;
>+ addr = vpd.id_tag == 0x82 ? VPD_BASE : 0;
>+
>+ for (i = 0; i < sizeof(vpd); i += 4) {
>+ ret = t3_seeprom_read(adapter, addr + i,
>+ (u32 *) ((u8 *) & vpd + i));
Randy Dunlap just submitted an updated CodingStyle - in short: &vpd -
you may want to take a look at it later on.
>+static int sf1_read(struct adapter *adapter, unsigned int byte_cnt, int cont,
>+ u32 * valp)
^
>+int t3_load_fw(struct adapter *adapter, const u8 * fw_data, unsigned int size)
>+{
>+ u32 csum;
>+ unsigned int i;
>+ const u32 *p = (const u32 *)fw_data;
>+ int ret, addr, fw_sector = FW_FLASH_BOOT_ADDR >> 16;
>+
>+ if (size & 3)
>+ return -EINVAL;
>+ if (size > FW_VERS_ADDR + 8 - FW_FLASH_BOOT_ADDR)
>+ return -EFBIG;
>+
>+ for (csum = 0, i = 0; i < size / sizeof(csum); i++)
>+ csum += ntohl(p[i]);
Does this checksum have bear resemblance to the IPv4 checksum?
>+ if (csum != 0xffffffff) {
>+ CH_ERR("%s: corrupted firmware image, checksum %u\n",
>+ adapter->name, csum);
>+ return -EINVAL;
>+ }
>+
>+ ret = t3_flash_erase_sectors(adapter, fw_sector, fw_sector);
>+ if (ret)
>+ goto out;
>+
>+ size -= 8; /* trim off version and checksum */
>+ for (addr = FW_FLASH_BOOT_ADDR; size;) {
>+ unsigned int chunk_size = min(size, 256U);
No need for the U.
>+static void pci_intr_handler(struct adapter *adapter)
>+{
>+ static struct intr_info pcix1_intr_info[] = {
>+ {F_MSTDETPARERR, "PCI master detected parity error", -1, 1},
>+ {F_SIGTARABT, "PCI signaled target abort", -1, 1},
constify if possible (also elsewhere)
-`J'
--
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
