On Wednesday 13 December 2006 17:54, Ulrich Kunitz wrote: > I mean on the other hands we break APIs for four or > eight bytes and here we spend a whole device strucuture and sysfs > directory for something the wlan device firmware represents with a > single bit. To call the housekeeping functions overkill under > these circumstances appears not to be very rational. > I do not consider the housekeeping functions overkill, but the function that it performs (eg. not confusing the user by keeping the LED off) can be done with less brute force.
> It should also be mentioned that the LEDs on the ZD1211 devices > are not independent devices, because they are partly controlled > by the firmware. That's exactly where some of the issues with your > patch are. > The link light can be treated as an independent device as long as the other LED bit is not flipped. As I mentioned before, fixing that isn't a problem. > Let the device drivers do the blinking, but give them a chance to > know about status changes at the MAC layer, without mandating to > implement a LED device. I guess you don't like the LED trigger code currently in d80211 then and would rather see it removed. As far as I can tell, this patch is just a symptom of that issue. -Michael Wu
pgp5JTyWMOqu6.pgp
Description: PGP signature
