On Fri, Jan 05, 2007 at 07:38:44AM +0100, Jarek Poplawski wrote: > > I'd only suggest to change "goto out;" to > "return NULL;" at the end of inetdev_init because > now RCU is engaged unnecessarily.
I agree. The RCU assignment should come before the out label. Can you send a patch? Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html