> +#define ATL1_STATS_LEN sizeof(atl1_gstrings_stats) / sizeof(struct > atl1_stats)
Just use an opencoded ARRAY_SIZE(). > +void atl1_read_pci_cfg(struct atl1_hw *hw, u32 reg, u16 * value) > +{ > + struct atl1_adapter *adapter = hw->back; > + pci_read_config_word(adapter->pdev, reg, value); > +} > + > +void atl1_write_pci_cfg(struct atl1_hw *hw, u32 reg, u16 * value) > +{ > + struct atl1_adapter *adapter = hw->back; > + pci_write_config_word(adapter->pdev, reg, *value); > +} Please just kill these types of wrappers and use pci_read_config_word/ pci_write_config_word directly. > +static inline bool atl1_eth_address_valid(u8 * p_addr) > +{ > + /* Invalid PermanentAddress ? */ > + if (((p_addr[0] == 0) && > + (p_addr[1] == 0) && > + (p_addr[2] == 0) && > + (p_addr[3] == 0) && (p_addr[4] == 0) && (p_addr[5] == 0) > + ) || (p_addr[0] & 1)) > + /* Multicast address or Broadcast Address */ > + return false; > + > + return true; > +} Don't we have a generic helper for this kind of thing? - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html