David Miller <[EMAIL PROTECTED]> wrote: > > Technically this is a bug fix too because once an SKB hits the > transmit function it should essentially be immutable, ie. you > shouldn't be writing to it. tcpdump sniffers could be looking > at the SKB, as one example.
We do have a way around that with skb_header_cloned. In fact it looks like VLAN should use it as otherwise TCP packets will get copied unnecessarily. This is still not optimal for AF_PACKET users since they will still cause things like VLANs to do the copy even when it isn't necessary because it doesn't touch any part of the packet that AF_PACKET actually looks at. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
