On Sat, Jan 20, 2007 at 08:10:27AM +1100, Herbert Xu wrote: > On Fri, Jan 19, 2007 at 12:06:41PM +0100, Jarek Poplawski wrote: > > > > [PATCH][NET] tcp_output: rare bad TCP checksum with 2.6.19 > > > > The patch "Replace CHECKSUM_HW by CHECKSUM_PARTIAL/CHECKSUM_COMPLETE" > > changed to unconditional copying of ip_summed field from collapsed > > skb. This patch reverts this change. > > > > All substantial work including heavy testing and diagnosing by: > > Michael Tokarev <[EMAIL PROTECTED]> > > > > Signed-off-by: Jarek Poplawski <[EMAIL PROTECTED]> > > Acked-by: Herbert Xu <[EMAIL PROTECTED]> > > Thanks for catching this! I'll take the credit for adding this bug :) > > Dave, we'll need this fix for 2.6.20 as well as 2.6.19. I was so impressed by the amount of work done by Michael that I magnified his merit and forgot to mention the role of Patrick and Herbert, particularly here:
> Since you're certain that this is being seen on the wire, one > possibility is that we've got a bug somewhere that's zeroing > skb->ip_summed on a packet with a partial checksum. which exactly pointed the reason. So, I apologize to them and, if there is such possibility, I would like to ask David Miller to change the description like that: --- [PATCH][NET] tcp_output: rare bad TCP checksum with 2.6.19 The patch "Replace CHECKSUM_HW by CHECKSUM_PARTIAL/CHECKSUM_COMPLETE" changed to unconditional copying of ip_summed field from collapsed skb. This patch reverts this change. The majority of substantial work including heavy testing and diagnosing by: Michael Tokarev <[EMAIL PROTECTED]> Possible reasons pointed by: Herbert Xu and Patrick McHardy. Signed-off-by: Jarek Poplawski <[EMAIL PROTECTED]> Acked-by: Herbert Xu <[EMAIL PROTECTED]> --- Regards, Jarek P. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
