On Tue, Jun 18, 2019 at 4:52 AM Nicolas Dichtel <nicolas.dich...@6wind.com> wrote: > >> From my point of view, if all tests are not successful by default, it > >> scares > >> users and prevent them to use those tests suite to validate their patches. > > > > For me, explicitly telling the user that a test was skipped, and /why/ > > it was skipped, is far better than excluding the test from the > > results: I don't want to waste someone's time with troubleshooting the > > script if they're expecting to see results for those tests when > > running tdc and nothing appears, or worse yet, stop using it because > > they think it doesn't work properly. > > > > I do believe the skip message should be improved so it better > > indicates why those tests are being skipped. And the '-d' feature > > should be documented. How do these changes sound? > If the error message is clear enough, I agree with you. The skip message > should > not feel like an error message ;-)
Very true. I think I just put that one in quickly and meant to come back to it later, but either way it's a bit too vague. I'll get that corrected, but I believe I'll add it to a separate patch after the requires functionality goes in. I want to update some of the documentation as well. Thanks, Lucas
