On Fri, 2 Feb 2007, Shinta Sugimoto wrote:

> > 
> > > +EXPORT_SYMBOL(xfrm_state_clone);
> > 
> > Why not EXPORT_SYMBOL_GPL ?
> > (for all of your exports).
> 
> Actually I don't have specific preference on either EXPORT_SYMBOL or
> EXPORT_SYMBOL_GPL.  It seemed to me that other functions defined in
> files under net/xfrm/ are using EXPORT_SYMBOL, so I followed that.

Hmm, you're right, most of them are not _GPL.

> Do you think EXPORT_SYMBOL_GPL is more appropriate in this case?

Well, I would have thought that users of xfrm were generally derivative of 
the kernel, but it doesn't make much sense to have only a couple of 
symbols exported as GPL, so probably keep it the way you already have it.


- James
-- 
James Morris
<[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to