RE: [PATCH net-next v2 1/2] qed: Add API for configuring NVM attributes.

Sat, 27 Jul 2019 18:39:40 -0700 


> -----Original Message-----
> From: [email protected] <[email protected]> On
> Behalf Of David Miller
> Sent: Sunday, July 28, 2019 2:30 AM
> To: Sudarsana Reddy Kalluru <[email protected]>
> Cc: [email protected]; Michal Kalderon <[email protected]>;
> Ariel Elior <[email protected]>
> Subject: Re: [PATCH net-next v2 1/2] qed: Add API for configuring NVM
> attributes.
> 
> From: Sudarsana Reddy Kalluru <[email protected]>
> Date: Fri, 26 Jul 2019 08:52:14 -0700
> 
> > +int qed_mcp_nvm_set_cfg(struct qed_hwfn *p_hwfn, struct qed_ptt
> *p_ptt,
> > +                   u16 option_id, u8 entity_id, u16 flags, u8 *p_buf,
> > +                   u32 len)
> > +{
> > +   u32 mb_param = 0, resp, param;
> > +   int rc;
>  ...
> > +   rc = qed_mcp_nvm_wr_cmd(p_hwfn, p_ptt,
> > +                           DRV_MSG_CODE_SET_NVM_CFG_OPTION,
> > +                           mb_param, &resp, &param, len, (u32
> *)p_buf);
> > +
> > +   return rc;
> 
> 'rc' is completely unnecessary, please just return the function result 
> directly.
> 
> Thank you.

Thanks for your comments. Will send the updated patch.

Reply via email to