Hi Stephen,
just a nitpick.
Stephen Hemminger schrieb:
> --- skge.orig/drivers/net/skge.c
> +++ skge/drivers/net/skge.c
> @@ -132,18 +132,93 @@ static void skge_get_regs(struct net_dev
> }
>
> /* Wake on Lan only supported on Yukon chips with rev 1 or above */
> -static int wol_supported(const struct skge_hw *hw)
> +static u32 wol_supported(const struct skge_hw *hw)
> {
> - return !((hw->chip_id == CHIP_ID_GENESIS ||
> - (hw->chip_id == CHIP_ID_YUKON && hw->chip_rev == 0)));
> + if (hw->chip_id == CHIP_ID_YUKON && hw->chip_rev != 0)
> + return WAKE_MAGIC | WAKE_PHY;
> + else
> + return 0;
> +}
You can delete that comment, if you write exactly, what the comment says:
if (hw->chip_id == CHIP_ID_YUKON && hw->chip_rev >= 1)
return WAKE_MAGIC | WAKE_PHY;
else
return 0;
Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
