On Fri, Feb 16, 2007 at 10:29:14AM -0800, Stephen Hemminger ([EMAIL PROTECTED])
wrote:
> On Fri, 16 Feb 2007 19:10:45 +0300
> Evgeniy Polyakov <[EMAIL PROTECTED]> wrote:
>
> > one of the possible fixes for select() after write() after ECONNRESET.
> >
> > Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]>
> >
> > diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
> > index b67e0dd..661ca0c 100644
> > --- a/net/ipv4/tcp.c
> > +++ b/net/ipv4/tcp.c
> > @@ -365,7 +365,7 @@ unsigned int tcp_poll(struct file *file, struct socket
> > *sock, poll_table *wait)
> > * blocking on fresh not-connected or disconnected socket. --ANK
> > */
> > if (sk->sk_shutdown == SHUTDOWN_MASK || sk->sk_state == TCP_CLOSE)
> > - mask |= POLLHUP;
> > + mask |= POLLHUP | POLLERR;
> > if (sk->sk_shutdown & RCV_SHUTDOWN)
> > mask |= POLLIN | POLLRDNORM | POLLRDHUP;
> >
> >
>
> No, that would end up setting error bit on normal shutdown. This is incorrect
> behaviour and might even be described in SUSE standard.
>
> There might even be LSB tests on this?
Maybe - I do not have it handy.
Otherwise we can extend select output mask to include hungup too
(getting into account that hungup is actually output event).
> --
> Stephen Hemminger <[EMAIL PROTECTED]>
--
Evgeniy Polyakov
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
