On Thu, Oct 17, 2019 at 11:44 AM Jakub Kicinski <jakub.kicin...@netronome.com> wrote: > > On Thu, 17 Oct 2019 11:10:06 -0700, Cong Wang wrote: > > On Wed, Oct 16, 2019 at 4:22 PM Jakub Kicinski wrote: > > > On Wed, 16 Oct 2019 15:42:28 -0700, Cong Wang wrote: > > > > > @@ -612,7 +613,7 @@ static int netem_enqueue(struct sk_buff *skb, > > > > > struct Qdisc *sch, > > > > > } > > > > > segs = skb2; > > > > > } > > > > > - qdisc_tree_reduce_backlog(sch, -nb, prev_len - len); > > > > > + qdisc_tree_reduce_backlog(sch, !skb - nb, prev_len - > > > > > len); > > > > > > > > Am I the only one has trouble to understand the expression > > > > "!skb - nb"? > > > > > > The backward logic of qdisc_tree_reduce_backlog() always gives me a > > > pause :S > > > > Yeah, reducing with a negative value is actually an add. Feel free > > to add a wrapper for this if you think it is better. > > I was avoiding adding the wrapper due to stable, but perhaps it should > be okay.
Up to you, you can defer the wrapper to net-next. > > How does this look? "nb - 1" with a comment is much better than "!skb - nb". Thanks.
