On Mon, Feb 19, 2007 at 08:11:59AM +0100, Jarek Poplawski wrote: > On Sun, Feb 18, 2007 at 10:27:19PM -0800, Ben Greear wrote: .. > > You are also changing the semantics of ASSERT_RTNL (assert *this thread* > > has rtnl, from the > > old behaviour: assert *some thread* has rtnl). It may be better this > > way, but it could break code that assumes the old behaviour.
If any code could assume the old behaviour it's simply a bug (eg. doing ASSERT_RTNL two times one after another could give different results). And it's logically wrong to: the same process is trying to acquire the same lock second time (pseudo recursively: it makes difficult lock verifying eg. by lockdep). Jarek P. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html