Ayaz Abdulla wrote:
The napi poll routine was missing the call to the optimized rx process
routine. This patch adds the missing call for the optimized path.
Signed-Off-By: Ayaz Abdulla <[EMAIL PROTECTED]>
------------------------------------------------------------------------
--- orig/drivers/net/forcedeth.c 2007-02-19 09:13:10.000000000 -0500
+++ new/drivers/net/forcedeth.c 2007-02-19 09:13:46.000000000 -0500
@@ -3104,13 +3104,17 @@
struct fe_priv *np = netdev_priv(dev);
u8 __iomem *base = get_hwbase(dev);
unsigned long flags;
+ u32 retcode;
- if (np->desc_ver == DESC_VER_1 || np->desc_ver == DESC_VER_2)
+ if (np->desc_ver == DESC_VER_1 || np->desc_ver == DESC_VER_2) {
pkts = nv_rx_process(dev, limit);
- else
+ retcode = nv_alloc_rx(dev);
+ } else {
pkts = nv_rx_process_optimized(dev, limit);
+ retcode = nv_alloc_rx_optimized(dev);
+ }
- if (nv_alloc_rx(dev)) {
+ if (retcode) {
You should update this patch to change the return values of the above
two functions from 'int' to 'u32', to match the code usage. Both
nv_rx_process() and nv_alloc_rx_optimized() return int, but you use them
as if they return u32.
Or alternately, use the Linux kernel standard of negative values
indicating failure, zero (or perhaps >=0) indicates success.
Otherwise, ACK.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
