From: Tariq Toukan <[email protected]>
Date: Mon, 4 May 2020 11:36:02 +0300
> When ENOSPC is set the idx is still valid and gets set to the global
> MLX4_SINK_COUNTER_INDEX. However gcc's static analysis cannot tell that
> ENOSPC is impossible from mlx4_cmd_imm() and gives this warning:
>
> drivers/net/ethernet/mellanox/mlx4/main.c:2552:28: warning: 'idx' may be
> used uninitialized in this function [-Wmaybe-uninitialized]
> 2552 | priv->def_counter[port] = idx;
>
> Also, when ENOSPC is returned mlx4_allocate_default_counters should not
> fail.
>
> Fixes: 6de5f7f6a1fa ("net/mlx4_core: Allocate default counter per port")
> Signed-off-by: Jason Gunthorpe <[email protected]>
> Signed-off-by: Tariq Toukan <[email protected]>
Applied, thank you.
