On 07/05/2020 21:45, Cong Wang wrote: > On Wed, May 6, 2020 at 1:31 PM Nikolay Aleksandrov > <niko...@cumulusnetworks.com> wrote: >> The patch looks good, but note that __netdev_update_features() used to >> return -1 >> before the commit in the Fixes tag above (between 6cb6a27c45ce and >> 00ee59271777). >> It only restored that behaviour. > > Good point! But commit fd867d51f889 is the one which started > using netdev_update_features() in netdev_sync_lower_features(), > your commits 00ee59271777 and 17b85d29e82c are both after it, > and returning whatever doesn't matter before commit fd867d51f889, > therefore, commit fd867d51f889 is the right one to blame? >
Right, that should be the one. > I will send V3 to just update this Fixes tag. > > Thanks! > Cheers, Nik
