Dirk <[EMAIL PROTECTED]> :
[...]
> I tried running 2.6.21-rc1 with the patch you mentioned, but it still
> has thesame speed problem. Building the driver with or without NAPI
> support makes no difference.

Thanks for testing.

Can you try the patch below on top of:

http://www.fr.zoreil.com/people/francois/misc/20070223-2.6.21-rc1-r8169-test.patch

Don't hurry: it's saturday. :o)

This patch fixes two problems:

  - Call unregister_netdev() before pci_disable_msi() to fix
    BUG_ON(irq_has_action(dev->first_msi_irq)) in drivers/pci/msi.c:658

  - Call RTL_W8(ChipCmd, CmdTxEnb | CmdRxEnb) in rtl_hw_start_8168()
    I don't know why, I have no specification of this device, I
    simply used the try & error method.

Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]>

---
 drivers/net/r8169.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: linux-2.6.21-rc1/drivers/net/r8169.c
===================================================================
--- linux-2.6.21-rc1.orig/drivers/net/r8169.c
+++ linux-2.6.21-rc1/drivers/net/r8169.c
@@ -1795,10 +1795,10 @@ static void __devexit rtl8169_remove_one
 
        flush_scheduled_work();
 
+       unregister_netdev(dev);
        if (tp->msi)
                pci_disable_msi(pdev);
        tp->msi = 0;
-       unregister_netdev(dev);
        rtl8169_release_board(pdev, dev, tp->mmio_addr);
        pci_set_drvdata(pdev, NULL);
 }
@@ -2060,6 +2060,7 @@ static void rtl_hw_start_8168(struct net
                tp->intr_event &= ~RxOverflow;
        }
 
+       RTL_W8(ChipCmd, CmdTxEnb | CmdRxEnb);
        rtl_set_rx_tx_desc_registers(tp, ioaddr);
 
        RTL_W8(Cfg9346, Cfg9346_Lock);
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to